-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cache for source line #4129
Conversation
f2d126b
to
6841e60
Compare
Can you please test to see if there's been a performance increase? On my end, I feel like the increase is smaller than expected. |
Yes, I confirm. It's much faster than before even though it's not ideal and still somewhat slow. I think the current increase is around 3x times faster. |
73a4876
to
0e71efd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retested again - now it's in the category of being usable again. We can further optimize this in the future after careful profiling. Meanwhile, good job! 👍
Also a first step towards solving #907
Your checklist for this pull request
Detailed description
...
Test plan
...
Closing issues
closes #4126