-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uplifting h8300 instructions to RzIL #4375
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Requires a test for RzIL, see how it's done, in
test/db/asm/h8300
- Windows linking error (you need to update Meson files
Creating library binrz/rz-run/rz-run.lib and object binrz/rz-run/rz-run.exp
rz_arch.lib(p_arch_h8300.c.obj) : error LNK2001: unresolved external symbol rz_h8300_il_config
rz_arch.lib(p_arch_h8300.c.obj) : error LNK2019: unresolved external symbol rz_h8300_il_opcode referenced in function h8300_op
binrz/rz-run/rz-run.exe : fatal error LNK1120: 2 unresolved externals
[1685/1953] Compiling C object binrz/rz-asm/rz-asm.exe.p/rz-asm.c.obj
ninja: build stopped: subcommand failed.
Command exited with code 1
Don't forget to rebase when you do your next change. |
@ashiskumarnaik have you had any chance to fix this PR? |
@XVilka Hi , I am still working on it. |
Any updates? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would require a "h8300" file with RzIL tests in this directoy as well: https://github.com/rizinorg/rizin/tree/dev/test/db/rzil
Including the "emulateme" type of test, where RzIL is used to emulate the part of the binary (see already existing tests in this directory).
For the instruction-level tests you will need to extend the https://github.com/rizinorg/rizin/blob/dev/test/db/asm/h8300 file with RzIL strings (see other files in that directory as an example)
Signed-off-by: Ashis Kumar Naik <[email protected]>
Signed-off-by: Ashis Kumar Naik <[email protected]>
Signed-off-by: Ashis Kumar Naik <[email protected]>
65f4734
to
ad19416
Compare
Your checklist for this pull request
Detailed description
RzIL upliftment for H8300
...
...
for #2080
...