Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HP PA-RISC: Migrate to Capstone and add basic analysis #4469

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

HP PA-RISC: Migrate to Capstone and add basic analysis #4469

wants to merge 2 commits into from

Conversation

XVilka
Copy link
Member

@XVilka XVilka commented May 4, 2024 •
edited
Loading

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

  • Remove GNU hppa plugin
  • Add Capstone-based disassembler
  • Add basic analysis plugin

Now it is able to derive control flow properly for most common instructions:

Screenshot 2024-05-05 at 1 20 08 AM

Test plan

CI is green

Closing issues

Partially addresses rizinorg/ideas#1
Partially addresses #2704

@XVilka XVilka added this to the 0.8.0 milestone May 4, 2024
@XVilka XVilka force-pushed the asan-hppa-arch branch from d1c404b to b933c63 Compare May 4, 2024 17:19
@XVilka XVilka force-pushed the asan-hppa-arch branch 2 times, most recently from 0d0adf3 to 793dece Compare May 4, 2024 18:30
wargio
wargio reviewed May 5, 2024
View reviewed changes
librz/arch/p/asm/asm_hppa_cs.c
ctx->insn = NULL;
ctx->count = cs_disasm(ctx->h, buf, len, a->pc, 1, &ctx->insn);
if (ctx->count <= 0) {
RZ_LOG_ERROR("HPPA: disasm error @ 0x%08" PFMT64x ", len = %d\n", a->pc, len);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's here for debugging. Once PR is ready I will remove.

@XVilka XVilka force-pushed the asan-hppa-arch branch from 793dece to 69ebddd Compare May 6, 2024 15:57
@XVilka XVilka mentioned this pull request May 23, 2024
Open
10 tasks
@XVilka XVilka mentioned this pull request Jun 3, 2024
Open
12 tasks
@XVilka XVilka force-pushed the asan-hppa-arch branch 2 times, most recently from c0de2e0 to bc42660 Compare September 18, 2024 16:31
@XVilka XVilka mentioned this pull request Nov 4, 2024
Open
@XVilka XVilka force-pushed the asan-hppa-arch branch 2 times, most recently from 39ff7a5 to 8d2e01e Compare November 24, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wargio wargio wargio left review comments

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc will be requested when the pull request is marked ready for review ret2libc is a code owner

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy will be requested when the pull request is marked ready for review kazarmy is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r will be requested when the pull request is marked ready for review thestr4ng3r is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ELF HPPA rz-test RzAnalysis RzAsm-Disassembler RzBin
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@XVilka @wargio