Add: Underline and strikethrough #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fficial markdown from John Gruber: http://daringfireball.net/projects/markdown/
| @@ -570,7 +570,36 @@ private int recursiveEmitLine(final StringBuilder out, final String in, final in | |||
| out.append(in.charAt(pos)); | |||
| } | |||
| break; | |||
| case EM_STAR: | |||
There was a problem hiding this comment.
Why did you remove the EM_START case?
There was a problem hiding this comment.
sorry that change can be reverted
|
Another issue: could you please tell me, where you found that underline and strike-through are contained as elements in the standard Markdown? I wrote txtmark against the specs from Daring Fireball, and there was (and still is no) underline or strike-through. |
|
http://daringfireball.net/linked/2015/11/05/markdown-strikethrough-slack Perhaps time to close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added underline and strikethrough function to the markdown like the official markdown from John Gruber: http://daringfireball.net/projects/markdown/