Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#556 - handle recursive references to deep schema definitions #1142

Merged
merged 3 commits into from
Jan 21, 2019

Conversation

epicfaace
Copy link
Member

@epicfaace epicfaace commented Jan 21, 2019

Reasons for making this change

Fixes #556 (case 2)

Also follows a series of recursive references, for example,

{
        definitions: {
          testdef: {
            $ref: "#/definitions/testdefref1",
          },
          testdefref1: {
            $ref: "#/definitions/testdefref2",
          },
          testdefref2: {
            type: "object",
            properties: {
              bar: { type: "string" },
            },
          },
        },
        type: "object",
        properties: {
          foo: { $ref: "#/definitions/testdef/properties/bar" },
        },
}

Checklist

  • I'm updating documentation
    • I've checked the rendering of the Markdown text I've added
    • If I'm adding a new section, I've updated the Table of Content
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
    • I've run npm run cs-format on my branch to conform my code to prettier coding style
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant