Fix corner case of empty items array #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbalboni
commented
Mar 23, 2018
| @@ -241,6 +241,26 @@ describe("utils", () => { | |||
| foo: 42, | |||
| }); | |||
| }); | |||
|
|
|||
| it("should fill array with additional items schema when items is empty", () => { | |||
There was a problem hiding this comment.
This is not a great test description, but I'm not sure what a better one would be.
There was a problem hiding this comment.
I think it is quite ok, it describes what it is testing.
|
To me this looks good, I suggest to merge this soon. |
|
@glasserc Can you merge this? |
|
Sorry for the delay! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
When upgrading from an old version I found that our code was creating array schemas in the shape shown in the test case, which was resulting in the
getDefaultFormStatefunction creating form data that had an array ofundefineds, instead of usingadditionalItemsas the item schema. This meant that required fields in the array item schema weren't triggering validation errors.Checklist
npm run cs-formaton my branch to conform my code to prettier coding style