Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a total count for Selected and Unselected co-authors #3

Closed
rkotze opened this issue Jan 3, 2019 · 1 comment
Closed

Add a total count for Selected and Unselected co-authors #3

rkotze opened this issue Jan 3, 2019 · 1 comment
Assignees
@rkotze
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@rkotze
Copy link
Owner

rkotze commented Jan 3, 2019

In the far right of the Selected and Unselected list item show a total count of the listed co-authors.
@rkotze rkotze added this to the v1.0 milestone Jan 3, 2019
@rkotze rkotze added the enhancement New feature or request label Jan 3, 2019
@rkotze rkotze removed this from the v1.0 milestone Feb 3, 2019
@rkotze
Copy link
Owner Author

rkotze commented Feb 3, 2019 •
edited
Loading

Investigation suggests this is not possible at the moment:

Stack overflow question

Dependant on this vs code issue being resolved

Looks like there was some confusion over the decorator to be used for badge count and this is the relevant issue to follow:
Badges in custom views and containers

@rkotze rkotze added the help wanted Extra attention is needed label Apr 14, 2020
rkotze added a commit that referenced this issue Dec 20, 2020
@rkotze
Show counts of co-authors as a vscode badge
dd74fb0 
Using the recently added FileDecoration provider it is possible to show counts as badges in Tree Item.

#3

Minor issue with tooltips overriden by resourceUri in tree item microsoft/vscode#113180
@rkotze rkotze self-assigned this Dec 20, 2020
rkotze added a commit that referenced this issue Dec 28, 2020
@rkotze
Add total count to change log
7a7af09 
#3
@rkotze rkotze closed this as completed Jan 3, 2021
rkotze added a commit that referenced this issue Jan 4, 2021
@rkotze
Ensure the counts update when adding a new co-author
bc04c0b 
Adding a new author via the .git-co-author file would not update the numbers.

Decided to have one event for when the list changes and means there does not beed to be a special _change method to subscribe to.

#3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rkotze rkotze

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rkotze