Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm shrinkwrap? #204

Closed
Schniz opened this issue Feb 15, 2015 · 3 comments
Closed

npm shrinkwrap? #204

Schniz opened this issue Feb 15, 2015 · 3 comments

Comments

@Schniz
Copy link

Schniz commented Feb 15, 2015

The npm shrinkwrap file prevents from downloading and installing sinopia in a closed network situation.
Although i can download the git repo, installing on my machine and then move it, I'd love to use sinopia to download sinopia 😏
@rlidwka
Copy link
Owner

rlidwka commented Feb 17, 2015

Yeah, you're right. Maybe we could remove hostnames from shrinkwrap leaving only versions.

@iostat42
Copy link

This affects me as well.

rlidwka added a commit that referenced this issue Mar 28, 2015
@rlidwka
remove "from" and "resolved" from shrinkwrap
0a38a70 
We should lock versions, but we shouldn't hardcode urls in it,
so people will be able to install this from private networks.

See #204 for details.
@rlidwka
Copy link
Owner

rlidwka commented Mar 30, 2015

Fixed in [email protected], how all urls are removed from shrinkwrap, but not the versions. I hope this will work.

@rlidwka rlidwka closed this as completed Mar 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rlidwka @Schniz @iostat42