-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interface for transmission's labels feature #220
Open
rsekman
wants to merge
12
commits into
rndusr:master
Choose a base branch
from
rsekman:labels
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you.
Looks great, apart from some style issues. Running flake8 should point those out.
|
Thanks! I think I got all of them fixed. Thank you also for pointing me to |
empty labels argument to add was not properly handled; ''.split() returns [''] not []
I'm also using isort for keeping imports predictably ordered.
Also, I've decided I'm not going to put more work into stig's current code. It
badly needs to be split into multiple projects, and the current design doesn't
really allow for supporting more clients, at least not as easily as it should
be. So, even though I generally welcome PRs, it's a waste of everyone's time at
the moment.
But I'll pull your existing PRs and probably maybe make another release with
them.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since version 3.00 transmission now supports labels for torrents, e.g., music, movies, iso. stig should provide an interface to this feature, meaning
add
should take an argument to label torrents as they are added