fix: Fixed null newParent parameter for Ajax Node/Tag/Folder contro…

…llers
roadiz · Jun 21, 2024 · 81d3570 · 81d3570
1 parent 3cacc45
commit 81d3570
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/lib/Rozier/src/AjaxControllers/AjaxFoldersController.php b/lib/Rozier/src/AjaxControllers/AjaxFoldersController.php
@@ -108,10 +108,9 @@ protected function updatePosition(array $parameters, Folder $folder): void
         /*
          * First, we set the new parent
          */
-        $parent = null;
-
         if (
             !empty($parameters['newParent']) &&
+            is_numeric($parameters['newParent']) &&
             $parameters['newParent'] > 0
         ) {
             /** @var Folder $parent */

diff --git a/lib/Rozier/src/AjaxControllers/AjaxNodesController.php b/lib/Rozier/src/AjaxControllers/AjaxNodesController.php
@@ -194,7 +194,11 @@ protected function updatePosition(array $parameters, Node $node): void
      */
     protected function parseParentNode(array $parameters): ?Node
     {
-        if (!empty($parameters['newParent']) && $parameters['newParent'] > 0) {
+        if (
+            !empty($parameters['newParent']) &&
+            is_numeric($parameters['newParent']) &&
+            $parameters['newParent'] > 0
+        ) {
             return $this->em()->find(Node::class, (int) $parameters['newParent']);
         } elseif (null !== $this->getUser()) {
             // If user is jailed in a node, prevent moving nodes out.

diff --git a/lib/Rozier/src/AjaxControllers/AjaxTagsController.php b/lib/Rozier/src/AjaxControllers/AjaxTagsController.php
@@ -300,10 +300,9 @@ protected function updatePosition($parameters, Tag $tag): void
         /*
          * First, we set the new parent
          */
-        $parent = null;
-
         if (
             !empty($parameters['newParent']) &&
+            is_numeric($parameters['newParent']) &&
             $parameters['newParent'] > 0
         ) {
             $parent = $this->em()