Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title cards do not support emoji #18

Closed
robby1066 opened this issue Jan 25, 2021 · 4 comments
Closed

Title cards do not support emoji #18

robby1066 opened this issue Jan 25, 2021 · 4 comments
Assignees
Labels
bug Something isn't working message creation Items that relate to the creation and recording of messages message viewing Items that relate to the experience of people viewing a message
Milestone

Comments

@robby1066
Copy link
Owner

Describe the bug

If a clip title contains an emoji character (examples: πŸ‘‹πŸ€¦β€β™‚οΈπŸŽ‰), it is not displayed on the generated title card.

Steps To Reproduce

  1. Go to compose a message
  2. Create a 'custom subject' clip
  3. Include an emoji in the clip title
  4. Create the message
  5. Observe the generated title card

Expected behavior

It's expected they would show on the title cards if they are used. Emojis are commonly used, and they are an easy way to add a graphic element to title cards.

Screenshots

Example of emojis entered as a clip title not rendering properly on the generated title card.
image

@robby1066 robby1066 added this to the For February milestone Jan 25, 2021
@robby1066 robby1066 self-assigned this Jan 25, 2021
@robby1066 robby1066 added the working on it This issue is actively being worked on label Jan 25, 2021
@robby1066 robby1066 modified the milestones: For February, For January Jan 25, 2021
@robby1066
Copy link
Owner Author

Testing suggests that the encoding of the HTML page that the title image is rendered from is an issue. Not sure if that's the only issue, but running a few more tests to figure it out.

@robby1066
Copy link
Owner Author

Making some progress on this one, emojis on title cards have gone from looking completely insane to simply looking broken, which suggests that this is both an encoding issue and a missing font on the server.

@robby1066
Copy link
Owner Author

Looks like after installing an emoji font on the server, emojis are rendering correctly. The emoji font may look different than the user's system font. That's unavoidable, although there are some options for which emoji font is used by the system.

The server the font is now using is Noto Color Emoji: https://www.google.com/get/noto/help/emoji/

Here is the same image from the original issue ☝️ rendered with working emojis.

image

I'll do some final testing on it, and make sure future deploys don't cause problems before closing.

@robby1066 robby1066 added the bug Something isn't working label Jan 26, 2021
@robby1066
Copy link
Owner Author

Fixed as of Jan 26, 2021

@robby1066 robby1066 added message creation Items that relate to the creation and recording of messages message viewing Items that relate to the experience of people viewing a message and removed working on it This issue is actively being worked on labels Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working message creation Items that relate to the creation and recording of messages message viewing Items that relate to the experience of people viewing a message
Projects
None yet
Development

No branches or pull requests

1 participant