Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's possible to hit the 'build' button with no clips defined #20

Closed
robby1066 opened this issue Jan 26, 2021 · 1 comment
Closed

It's possible to hit the 'build' button with no clips defined #20

robby1066 opened this issue Jan 26, 2021 · 1 comment
Assignees
Labels
bug Something isn't working message creation Items that relate to the creation and recording of messages
Milestone

Comments

@robby1066
Copy link
Owner

Describe the bug

The logic for when the 'build' button is present checks to make sure that there are no clips present in a message that are missing a recorded video. The problem with that logic is that it returns true when there are no clips present at all.

Steps To Reproduce

  1. Go to compose a message
  2. Clear all the clips
  3. Save message
  4. Observe the "Ready to build" banner on the message edit page

Expected behavior

You shouldn't be able to attempt to build an empty message (which will throw an error anyway), and you should be prompted for how to correct the situation when there are no clips.

Screenshots

image

@robby1066 robby1066 added the bug Something isn't working label Jan 26, 2021
@robby1066 robby1066 added this to the For January milestone Jan 26, 2021
@robby1066 robby1066 self-assigned this Jan 26, 2021
@robby1066
Copy link
Owner Author

Fixed on Jan 25, 2021

image

@robby1066 robby1066 added the message creation Items that relate to the creation and recording of messages label Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working message creation Items that relate to the creation and recording of messages
Projects
None yet
Development

No branches or pull requests

1 participant