Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be able to rearrange clips using keyboard navigation #42

Closed
robby1066 opened this issue Feb 23, 2021 · 5 comments
Closed

Be able to rearrange clips using keyboard navigation #42

robby1066 opened this issue Feb 23, 2021 · 5 comments
Labels
accessibility Improve accessibility of something enhancement New feature or request message creation Items that relate to the creation and recording of messages
Milestone

Comments

@robby1066
Copy link
Owner

What's the problem you're hoping this new feature will solve?

If someone is not using a mouse, clips for a message cannot be re-ordered. That is a fairly common action, and it's a barrier to getting the full experience of the app.

Description of feature

This feature would allow people using a keyboard or other non-mouse device to move clips up or down in the sort order of a message on both the message create page, and the post-create edit screen.

Alternatives and workarounds

You have to use a mouse or trackpad to re-order clips.

Additional context

Github has a decent implementation of this on their issue listing pages that reveals itself when tabbing through, but doesn't clutter up the mouse-driven reordering experience.

See the arrow in the middle (focused) item in this screenshot for an example:
image

@robby1066 robby1066 added enhancement New feature or request accessibility Improve accessibility of something message creation Items that relate to the creation and recording of messages labels Feb 23, 2021
@robby1066 robby1066 added this to the For March milestone Feb 23, 2021
@robby1066
Copy link
Owner Author

See the Sortable documentation for some starting points on how to accomplish this.

@robby1066 robby1066 added the working on it This issue is actively being worked on label Mar 15, 2021
@robby1066
Copy link
Owner Author

robby1066 commented Mar 15, 2021

Working on the placement of the arrows. This seems to make the most sense. When focused by the keyboard, both arrows (if available) take over the place of the draggable handle.
Screenshot 2021-03-15 at 18 25 14

This image shows the basic placement, but in real life it would be an incorrect implementation because there should not be an 'up' arrow on the very first item, and should not be a 'down' arrow on the very last item.

@robby1066
Copy link
Owner Author

@robby1066
Copy link
Owner Author

This is implemented in development now. Needs to be deployed to production and then will do final testing and close the issue.

@robby1066
Copy link
Owner Author

Tested and deployed on March 18

@robby1066 robby1066 removed the working on it This issue is actively being worked on label Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Improve accessibility of something enhancement New feature or request message creation Items that relate to the creation and recording of messages
Projects
None yet
Development

No branches or pull requests

1 participant