Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

funnyThingsApp: add missing bash scripts #21

Merged
merged 1 commit into from
Nov 16, 2021
Merged

Conversation

Nicogene
Copy link
Member

The scripts are needed for performing the actions, I forgot to copy them when I did the porting from appsAway.

Please review the code.

@Nicogene Nicogene added the bug label Nov 16, 2021
@Nicogene Nicogene requested a review from vtikha November 16, 2021 09:39
@Nicogene Nicogene self-assigned this Nov 16, 2021
@Nicogene Nicogene changed the title funnyThingsApp: add missing bash scripts [WIP] funnyThingsApp: add missing bash scripts Nov 16, 2021
@Nicogene Nicogene marked this pull request as draft November 16, 2021 09:40
@Nicogene Nicogene marked this pull request as ready for review November 16, 2021 09:41
@Nicogene Nicogene changed the title [WIP] funnyThingsApp: add missing bash scripts funnyThingsApp: add missing bash scripts Nov 16, 2021
@Nicogene
Copy link
Member Author

These changes have been tested successfully on the iCubErzelli02

Copy link
Member

@vtikha vtikha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌🏼

@Nicogene Nicogene merged commit bb63e4e into master Nov 16, 2021
@Nicogene Nicogene deleted the fix/funnyThingsApp branch November 16, 2021 09:44
@alecive
Copy link
Member

alecive commented Nov 16, 2021

So you are telling me you are still using this repo after so many years? That's hilarious.
The GUI is amazing! You should add loops to repeat behaviors ad infinitum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants