Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMC_BLDC: Update codegen + Fix initialization of htim2.Init.Period #253

Merged
merged 4 commits into from
Mar 1, 2022

Conversation

sgiraz
Copy link
Contributor

@sgiraz sgiraz commented Feb 22, 2022

What changes in this PR:

  • The generated code now contains the addition of the SW Current Limiter that aims to limit the current when it exceeds the Peak Limit Ipeak.
  • The encoder configuration is now initialized using the MainConf.pwm.poles instead of the hardcoded value

Notes:
The code has been tested successfully on the ems-amc_bldc-wrist-setup.

cc @pattacini

@sgiraz sgiraz requested a review from marcoaccame February 22, 2022 10:52
@sgiraz sgiraz self-assigned this Feb 22, 2022
@pattacini
Copy link
Member

Hi @sgiraz
We need to regenerate the code from the model as we fixed the bug on the SW Current Limiter.

@sgiraz
Copy link
Contributor Author

sgiraz commented Feb 25, 2022

Hi @pattacini, the codegen has been updated to the last changes on study-amc-bldc@master.

I'll perform a quick test next Monday, then I think this PR can be safely merged.

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sgiraz
Copy link
Contributor Author

sgiraz commented Feb 28, 2022

application06 well tested with the new changes!
@marcoaccame feel free to merge!

cc @pattacini

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick further comment.

@pattacini
Copy link
Member

I think we can safely merge the PR as it mostly pertains to changes done to the codegen.

@pattacini pattacini merged commit 63c097d into robotology:devel Mar 1, 2022
@sgiraz sgiraz deleted the feat/amc-bldc-current-limit branch March 2, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants