Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amc-bldc: now the motor configuration is done on motor_configmessage reception #300

Merged
merged 5 commits into from
Sep 22, 2022

Conversation

valegagge
Copy link
Member

@ale-git and I updated the amc-bldc fw in order to configure the motor device (composed by analog, rotor encoder and PWM) in run time on motor_configmessage reception.

We tested the fw on wrist setup and it works fine.

cc @mfussi66

@sgiraz
Copy link
Contributor

sgiraz commented Sep 16, 2022

Nicely done @valegagge and @ale-git! 🚀

Do you need to update the robots-configuration files as well?

@marcoaccame
Copy link
Contributor

Hi, I will review the PR later in the afternoon or on Monday at most.

@valegagge
Copy link
Member Author

Nice done @valegagge and @ale-git! 🚀

Do you need to update the robots-configuration files as well?

yes, here

…y configured. Useful in case yarprobotinterface is restarted without restarting the boards.
Copy link
Contributor

@marcoaccame marcoaccame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok @ale-git, that is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants