Calibration type 14 update fw #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valegagge
requested changes
Jun 5, 2023
emBODY/eBcode/arch-arm/board/ems004/appl/v2/src/eoappservices/EOthePOS_hid.h
Outdated
Show resolved
Hide resolved
marcoaccame
requested changes
Jun 6, 2023
emBODY/eBcode/arch-arm/board/ems004/appl/v2/src/eoappservices/EOthePOS.c
Outdated
Show resolved
Hide resolved
|
Apart from the small thing above all is great. Well done. P.S. I assume that everything was tested on the robot and ready to go. |
Kinda yes, |
valegagge
approved these changes
Jun 9, 2023
MSECode
force-pushed
the
feature/configCalib14
branch
from
5c84505 to
1d10432
Compare
FAP calibration official params in calibrator config file Kept POS calibration group Kept MC calibration group calibration does only FAP calibration and qenc moved to hard stop Add dummy eo_pos_Calibrate method when service not used Update version for ETH boards Remove calibrated boolean that is not used for any checks Fix conversion between 2 rot enums Add enum type return in error line Fix invert direction if condition Fix rot + offset with module of 360 Removed useless info in debug line
MSECode
force-pushed
the
feature/configCalib14
branch
from
1d10432 to
b82249c
Compare
|
Tested on the robot by @MSECode. All is fine. |
marcoaccame
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
ETHboards, since we have changed code that is shared for all of those boards.eo_pos_CalibrateinPOSfor passing to the POS service calibration values for absolute encoder coming from the calibrators_eo_pos_joint_calibrateands_eo_pos_sensor_configfor calibrate absolute sensor managed by POS serviceCalibratorsclass by reducing the steps and removing processes that are not necessary and/or meaninglessJointSetclass, therefore encoder gets re-calibrated after POS service starts using data coming from calibrator configuration file