-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMDBLDC: add thermal model running at 10ms and reusable functions from codegen (icub-fw-models@2e2670b) #391
Conversation
.../arch-arm/board/amcbldc/application/src/app-board-amcbldc/embot_app_board_amcbldc_theMBD.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @marcoaccame
Please, also review the STRAIN2c patch.
emBODY/eBcode/arch-arm/board/ems004/appl/v2/src/eoappservices/EOtheCANdiscovery2.c
Show resolved
Hide resolved
emBODY/eBcode/arch-arm/board/ems004/appl/v2/cfg/eoemsappl/EOMtheEMSapplCfg_cfg.h
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The strain2c
patch is OK as long as you update the application versions of the ETH boards.
Some minor changes are needed. To group them all in here:
- update application version of the
ems
,mc4plus
,mc2plus
; - propagate changes of MBD also for the
amc2c
board in functionembot::app::board::amc2c::theMBD::Impl::tick()
; - increase application version of
amcbldc
.
The application version of the amcbldc
is inside file embot_app_board_amcbldc_info.cpp
:
namespace embot::app::board::amcbldc::info {
constexpr embot::prot::can::applicationInfo applInfo
{
embot::prot::can::versionOfAPPLICATION {2, 0, 2},
embot::prot::can::versionOfCANPROTOCOL {2, 0}
};
emBODY/eBcode/arch-arm/board/ems004/appl/v2/src/eoappservices/EOtheCANdiscovery2.c
Show resolved
Hide resolved
emBODY/eBcode/arch-arm/board/ems004/appl/v2/cfg/eoemsappl/EOMtheEMSapplCfg_cfg.h
Show resolved
Hide resolved
.../arch-arm/board/amcbldc/application/src/app-board-amcbldc/embot_app_board_amcbldc_theMBD.cpp
Outdated
Show resolved
Hide resolved
@marcoaccame FYI this change requires also the change of the keil project, by adding the thermal model sources |
Done in
Done in
Done in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's OK, @mfussi66. Thanks.
This PR aligns the AMCBLDC code to the latest mbd code generation, with the following features:
cc @pattacini