Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix for not causing joints to go in hw fault at yri restart #400

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

MSECode
Copy link
Contributor

@MSECode MSECode commented Jul 25, 2023

Fix for avoiding error of hard limit reached when yarprobotinterface is stopped and restarted

Fault visible only on MAIS due to the restoring of default values at yarprobotinterface restart.
This is just a temporary fix, which allows to work more easily on iCub3 robots and it will be substituted by a proper patch soon. Update versioning for fw and fix error for changed method in amc

…yarprobotinteface restarting

Fault visible only on MAIS due to the restoring of default values at
yarprobotinterface restart.
This is just a temporary fix, which allows to work more easily on iCub3
robots and it will be substituted by a proper patch soon.
Update versioning for fw and fix error for changed method in amc
Copy link
Member

@valegagge valegagge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks!!! :)

Just a side note: we can remove the debug function MController_Debug_Enc_values

@valegagge valegagge requested review from marcoaccame and ale-git July 25, 2023 20:13
@valegagge
Copy link
Member

The PR with the executables file is robotology/icub-firmware-build#95.

This PR has been tested on the iCubGenova11 successfully by @MSECode! 🚀

Copy link
Contributor

@marcoaccame marcoaccame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks

@marcoaccame marcoaccame merged commit 2a63f52 into robotology:devel Jul 26, 2023
@MSECode MSECode deleted the fix/armCalibFaults branch July 28, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants