Add comment lines for temperature reading #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSECode
force-pushed
the
fix/documentTempReading
branch
from
d6f86b2 to
92e2a00
Compare
…the TDB and its I2C protocol
MSECode
force-pushed
the
fix/documentTempReading
branch
from
92e2a00 to
3f58d44
Compare
valegagge
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR I've added some lines of comment to the file
emBODY/eBcode/arch-dspic/board/2foc/appl/2FOC-V3/src/i2cTsens.cso that one can understand what the different registries mean and how the reading and transmission of the temperatures values works in relation to the TDB board and how the transmission is managed on the I2C protocol between 2foc and TDB.So, in this PR we just have added comments explaining the whole pipeline responsible for the temperature reading and transmission over I2C and especially the reason why we are configuring the sensor in a specific manner.