Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iCubGenova04 - Activate all FT-IMU sensors on the legs and feet #110

Merged

Conversation

nunoguedelha
Copy link
Contributor

@nunoguedelha nunoguedelha commented Aug 6, 2019

This completes the activation of the IMU sensors embedded in the legs and feet FT sensor boards as a dependency of the walking on inclined plane implementations, typically https://github.com/dic-iit/element_walking-on-inclined-plane/issues/40.

PR changes

  • update the names of IMUs on the left and right legs, matching the names used in the PR Add legs FT IMU frames - address review icub-models-generator#113. All the xml files configuring the devices of type embObjIMU, the remappers and wrappers already existed, only the names were updated.
  • add the respective configuration files to the startup config icub_wbd_inertials.

CC @lia2790 @S-Dafarra @fiorisi @fjandrad @prashanthr05

@nunoguedelha nunoguedelha self-assigned this Aug 6, 2019
@nunoguedelha nunoguedelha changed the base branch from calib/joint-offsets-for-ft-calib to devel_iCubGenova04 August 6, 2019 23:04
@nunoguedelha
Copy link
Contributor Author

I have restored the "integration branch" devel_iCubGenova04, coinciding now with the branch calib/joint-offsets-for-ft-calib on commit 1785b40 which has been used on the Green iCub (iCubGenova04) until now.
I've updated the PR accordingly. As a side note, tomorrow I will PR the branch calib/joint-offsets-for-ft-calib.

@traversaro
Copy link
Member

cc @Nicogene this PR touches the configuration of the embObjIMU devices, so you could be interested to check it out due to your work in robotology/icub-main#592 .

@nunoguedelha
Copy link
Contributor Author

CC @prashanthr05

@nunoguedelha nunoguedelha force-pushed the feature/activate-ft-imus-on-the-feet branch from 43f7d36 to 186a559 Compare October 21, 2019 17:35
@nunoguedelha nunoguedelha changed the title WIP: iCubGenova04 - Activate all FT-IMU sensors on the legs and feet iCubGenova04 - Activate all FT-IMU sensors on the legs and feet Oct 21, 2019
@nunoguedelha
Copy link
Contributor Author

Rebased.

@nunoguedelha
Copy link
Contributor Author

ping @prashanthr05 @lia2790 @MiladShafiee

Copy link
Contributor

@S-Dafarra S-Dafarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nunoguedelha nunoguedelha merged commit ef2e9b2 into devel_iCubGenova04 Oct 22, 2019
@nunoguedelha nunoguedelha deleted the feature/activate-ft-imus-on-the-feet branch October 22, 2019 14:36
@prashanthr05
Copy link
Contributor

prashanthr05 commented Oct 25, 2019

I think we will have to make changes to the right leg inertials

    <!-- DEVICES FOR INERTIAL SENSORS ON MTB, EMS AND FT STRAIN BOARDS -->
    <devices file="hardware/inertials/right_leg-eb8-IMU.xml" />
    <devices file="hardware/inertials/right_leg-eb8-inertials.xml" />
    <devices file="hardware/inertials/right_leg-eb9-IMU.xml" />
    <devices file="hardware/inertials/right_leg-eb9-inertials.xml" />
    <devices file="hardware/inertials/right_leg-eb11-inertials.xml" />

    <!-- REMAPPERS FOR INERTIAL SENSORS ON MTB, EMS AND FT STRAIN BOARDS -->
    <devices file="wrappers/inertials/right_leg-inertials_remapper.xml" />

    <!-- WRAPPERS FOR INERTIAL SENSORS ON MTB, EMS AND FT STRAIN BOARDS -->
    <devices file="wrappers/inertials/right_leg-inertials_wrapper.xml" />

devices must be replaced by xi:include and file with href

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants