Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check on empty input #37

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Added check on empty input #37

merged 1 commit into from
Jun 10, 2021

Conversation

lauracavaliere
Copy link
Contributor

This PR adds a check for empty input for googleSynthesis. It also propagates the error on the /googleSynthesis/state:o as Empty_input which notifies the user that the module has received an empty input.

@Nicogene Nicogene requested a review from vtikha June 9, 2021 16:15
Copy link
Member

@vtikha vtikha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vtikha vtikha merged commit 650a117 into master Jun 10, 2021
@vtikha vtikha deleted the empty_input_check branch June 10, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants