-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Texture retargeting #100
Texture retargeting #100
Conversation
…update the skin retargeting policy
…edback to cast the force feedback to the user
… the bug of the home values
…utomatically if a skin is working fine
…nd teleoperation classes
… to the RobotSkin Class
…n data derivatives
ad22d93
to
31888b5
Compare
Done. I also changed the base branch to
Done in 2fa7476 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the circumstances, we can simply merge this PR as is once the CI passes
If you want to have a look to the PR and code (however, it is a bit large), I invite you to do so. If there are suggestions, I can fix it in the following days. In any case, I have been carefully updated the code to be clean and with clear necessary explanation and documentation. I am also available later on, if you have some doubts or feedbacks! |
Should I continue with the merge @S-Dafarra ?! |
I quickly skimmed through the code and seems good to me! I also appreciated the documentation in the configuration files and in the code! Thanks a million, @kouroshD. Merging! |
Probably we need to rebase on top of
devel
due to #97.As I mentioned before, I do not set up my systems now, so I cannot do it now.
@S-Dafarra you can simply rebase it on top of
devel
, and build to check. You should also fix the deprecation problems as in #97 later. If you cannot, I can do it in these days, but not today for sure.Avoid doing any squashing, I would like to keep the commit history clean.