Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Texture retargeting #100

Merged
merged 39 commits into from
Jun 9, 2022
Merged

Conversation

kouroshD
Copy link
Collaborator

@kouroshD kouroshD commented Jun 8, 2022

Probably we need to rebase on top of devel due to #97.

As I mentioned before, I do not set up my systems now, so I cannot do it now.
@S-Dafarra you can simply rebase it on top of devel, and build to check. You should also fix the deprecation problems as in #97 later. If you cannot, I can do it in these days, but not today for sure.
Avoid doing any squashing, I would like to keep the commit history clean.

@kouroshD kouroshD requested a review from S-Dafarra June 8, 2022 13:29
@kouroshD kouroshD self-assigned this Jun 8, 2022
@kouroshD kouroshD added the enhancement New feature or request label Jun 8, 2022
kouroshD added 27 commits June 8, 2022 15:56
…edback to cast the force feedback to the user
@S-Dafarra S-Dafarra force-pushed the texture_retargeting_pr_devel_patience branch from ad22d93 to 31888b5 Compare June 8, 2022 13:56
@S-Dafarra S-Dafarra changed the base branch from devel to master June 8, 2022 13:57
@S-Dafarra
Copy link
Collaborator

@S-Dafarra you can simply rebase it on top of devel, and build to check.

Done. I also changed the base branch to master

You should also fix the deprecation problems as in #97

Done in 2fa7476

Copy link
Collaborator

@S-Dafarra S-Dafarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the circumstances, we can simply merge this PR as is once the CI passes

@kouroshD
Copy link
Collaborator Author

kouroshD commented Jun 8, 2022

Given the circumstances, we can simply merge this PR as is once the CI passes

If you want to have a look to the PR and code (however, it is a bit large), I invite you to do so. If there are suggestions, I can fix it in the following days. In any case, I have been carefully updated the code to be clean and with clear necessary explanation and documentation.

I am also available later on, if you have some doubts or feedbacks!

@kouroshD
Copy link
Collaborator Author

kouroshD commented Jun 8, 2022

Should I continue with the merge @S-Dafarra ?!

@S-Dafarra
Copy link
Collaborator

I quickly skimmed through the code and seems good to me! I also appreciated the documentation in the configuration files and in the code! Thanks a million, @kouroshD. Merging!

@S-Dafarra S-Dafarra merged commit 4f9db93 into master Jun 9, 2022
@S-Dafarra S-Dafarra deleted the texture_retargeting_pr_devel_patience branch October 13, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants