Improved compilation time of WBToolbox blocks by optimizing Blockinitialization()
#190
Conversation
|
Why "Draft"? |
|
I was still building superbuild with the changes. Although I know that the changed file is simply copied to the install folder, I wanted to have that check end to end, building, then running a compilation under Matlab. Anyway we can move the PR to ready now, since it's a trivial change. |
There was a problem hiding this comment.
Thanks @nunoguedelha for fixing this problem, it has a huge impact on the workflow of so many people!
Meanwhile I try to figure out what's happening with CI, I ask you if you can remove the link to the private repo you added in the description of the commit (also in the PR description). Thanks!
|
Well, great team work with all of you! And thx @Giulero for the stats on the code lines. @diegoferigo I'll push force a commit to remove the reference you mentioned. |
…kinitialization()` code. - Refer to robotology#189 for full details. - In `Blockinitialization()` current implementation, we first retrieve the list of all the WBT blocks in the model. Then we look for the closest Config block, starting from the block's scope, and going up in the tree. - The optimization consisted in retrieving only the Config blocks (name under mask is `ImConfig`) instead of the full list. the reduced list is enough for the second regexp, when looking for the closest Config, since only the lines containing `ImConfig` are supposed to match the regexp. - This change is compatible with the support of multi-config models.
nunoguedelha
force-pushed
the
feature/improve-wbt-blocks-initialisation-during-compilation
branch
from
71b0674 to
771c7f8
Compare
|
Merged into |
nunoguedelha
deleted the
feature/improve-wbt-blocks-initialisation-during-compilation
branch
This is related to #189. Refer to those issues for full details.
Improved compilation time of WBToolbox blocks by optimizing
Blockinitialization()code:Blockinitialization()current implementation, we first retrieve the list of all the WBTblocks in the model. Then we look for the closest Config block, starting from the block's
scope, and going up in the tree.
ImConfig)instead of the full list. the reduced list is enough for the second regexp, when looking for
the closest Config, since only the lines containing
ImConfigare supposed to match the regexp.