Fix InstallBasicPackageFiles preserving compatibility #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claudiofantacci
added a commit
to robotology/how-to-export-cpp-library
that referenced
this pull request
Jan 20, 2017
Update InstallBasicPackageFiles from YCM due to the following PR: robotology/ycm-cmake-modules#112 Fixes #6
claudiofantacci
added a commit
to claudiofantacci/AutoCanny
that referenced
this pull request
Jan 20, 2017
Update InstallBasicPackageFiles from YCM due to the following PR: robotology/ycm-cmake-modules#112 Also update CMakeLists.txt files to account for the Update. CMake code is now more clean.
|
can you please add a line to describe your changes in |
|
Will do. |
|
Done! |
drdanz
approved these changes
Jan 27, 2017
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an error in
InstallBasicPackageFiles.cmakefile which was forcing the user to set in its project cmake file specific GLOBAL variable for properly export the project.In particular, under specific circumstances,
set_and_check(${_IBPF_VARS_PREFIX}_INCLUDEDIR \"@PACKAGE_${_IBPF_VARS_PREFIX}_INCLUDEDIR@\")was failing while importing a target usingfind_package(<target_name>).This behaviour is fixed changing set_and_check() with set(), thus preserving compatibility.
Furthermore, the file documentation has also been updated.