Move RobotType and MAC address detection

src/main/java/frc/robot/Robot.java

@@ -11,18 +11,12 @@
 import edu.wpi.first.wpilibj.livewindow.LiveWindow;
 import edu.wpi.first.wpilibj.smartdashboard.SmartDashboard;
 import edu.wpi.first.wpilibj2.command.CommandScheduler;
-import frc.robot.util.MACAddress;
+import frc.robot.util.RobotType;
 
 public class Robot extends TimedRobot {
   /** Singleton Stuff */
   private static Robot instance = null;
 
-  public enum RobotType {
-    COMPETITION,
-    CRANE,
-    BONK;
-  }
-
   public static Robot getInstance() {
     if (instance == null) instance = new Robot();
     return instance;
@@ -32,23 +26,10 @@ public static Robot getInstance() {
   public final Controls controls;
   public final Subsystems subsystems;
 
-  public static final MACAddress COMPETITION_ADDRESS = MACAddress.of(0x38, 0xd9, 0x9e);
-  public static final MACAddress BONK_ADDRESS = MACAddress.of(0x33, 0x9D, 0xE7);
-  public static final MACAddress CRANE_ADDRESS = MACAddress.of(0x22, 0xB0, 0x92);
-
-  private static RobotType getTypeFromAddress() {
-    if (CRANE_ADDRESS.exists()) return RobotType.CRANE;
-    if (BONK_ADDRESS.exists()) return RobotType.BONK;
-    if (!COMPETITION_ADDRESS.exists())
-      DriverStation.reportWarning(
-          "Code running on unknown MAC Address! Running competition code anyways", false);
-    return RobotType.COMPETITION;
-  }
-
   protected Robot() {
     // non public for singleton. Protected so test class can subclass
     instance = this;
-    robotType = getTypeFromAddress();
+    robotType = RobotType.getCurrent();
 
     LiveWindow.disableAllTelemetry();
 

src/main/java/frc/robot/util/RobotType.java

@@ -0,0 +1,36 @@
+package frc.robot.util;
+
+import edu.wpi.first.wpilibj.DriverStation;
+
+public enum RobotType {
+  COMPETITION(0x38, 0xd9, 0x93),
+  CRANE(0x22, 0xb0, 0x92),
+  BONK(0x33, 0x9d, 0xe7);
+
+  @SuppressWarnings("ImmutableEnumChecker")
+  private final MACAddress macAddress;
+
+  RobotType(int a, int b, int c) {
+    macAddress = MACAddress.of(a, b, c);
+  }
+
+  private static RobotType detectType() {
+    for (RobotType robotType : RobotType.values()) {
+      if (robotType.macAddress.exists()) {
+        return robotType;
+      }
+    }
+    DriverStation.reportWarning(
+        "Code running on unknown MAC Address! Running competition code anyways", false);
+    return COMPETITION;
+  }
+
+  private static RobotType currentRobotType;
+
+  public static RobotType getCurrent() {
+    if (currentRobotType == null) {
+      currentRobotType = detectType();
+    }
+    return currentRobotType;
+  }
+}