Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support xib and storyboard obfuscation with command line option #130

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ptwoms
Copy link
Contributor

@ptwoms ptwoms commented Jun 14, 2021

I added this because my projects use storyboards and xibs and it takes time to update xml files manually after source obfuscation.
IB XML obfuscation is added as an option (--include-ibxmls) and is not enabled by default.

@rockbruno
Copy link
Owner

I actually supported this feature at one point, but I removed it because there were far too many reports of things not being obfuscated correctly (for example, obfuscating a method configured as an outlet) because the storyboards have a billion different ways of storing this information. I considered it impossible to maintain properly, are you confident that this works for all cases?

@ptwoms
Copy link
Contributor Author

ptwoms commented Jun 15, 2021

It basically looks for any xml tags with customClass attribute for custom class (and customModule for ignore modules) as long as the class name is in the obfuscated dictionary. And selector with parent tag connections (destination -> customModule for ignore modules) for IBAction. It is working fine on the projects I am working on.

I haven't come across other patterns yet. If they can provide the sample IB file I can look into it. That's why I put this option as experimental.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants