You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
One of the features intended in #2207 was to detect the rock-ons with container(s) using host networking so that we disable the Networking customization options accordingly. Unfortunately, the underlying logic was lost during #2207's development and we now fail to accurately detect such rock-ons.
As mentioned in #2239 (comment), the culprit is the following line...
... in which the running_filters shouldn't be applied there. Indeed, these are intended to detect running rock-ons, which shouldn't be used here and is in contradiction with the all=True flag that we need instead (and use).
It has also become evident we need to establish unit test coverage of system/docker.py to catch such problems/regressions.
The text was updated successfully, but these errors were encountered:
out to be unnecessary and contradicting the intended logic (rockstor#2242)
Accordingly, rename probe_running_containers() to probe_containers()
as we don't always probe for "running" containers.
One of the features intended in #2207 was to detect the rock-ons with container(s) using host networking so that we disable the Networking customization options accordingly. Unfortunately, the underlying logic was lost during #2207's development and we now fail to accurately detect such rock-ons.
As mentioned in #2239 (comment), the culprit is the following line...
rockstor-core/src/rockstor/system/docker.py
Lines 152 to 153 in 1223360
... in which the
running_filters
shouldn't be applied there. Indeed, these are intended to detect running rock-ons, which shouldn't be used here and is in contradiction with theall=True
flag that we need instead (and use).It has also become evident we need to establish unit test coverage of
system/docker.py
to catch such problems/regressions.The text was updated successfully, but these errors were encountered: