Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Samba restore restrictions #487 #492

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

Hooverdan96
Copy link
Member

@Hooverdan96 Hooverdan96 commented Oct 4, 2024

Fixes #487
Fixes #457

This pull request's proposal

Add comment clarifying which parts of Samba exports can't be restored yet.

Checklist

  • With the proposed changes no Sphinx errors or warnings are generated.
  • I have added my name to the AUTHORS file, if required (descending alphabetical order).

Fixes rockstor#487.

Add comment clarifying which parts of Samba exports can't be restored yet.
@Hooverdan96
Copy link
Member Author

@phillxnet, see whether this is sufficient to clarify until there is time to address this gap.

Copy link
Member

@FroggyFlox FroggyFlox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for taking care of this so quickly, @Hooverdan96 ! It's much better to have that specified in our docs to clarify the situation.
I only have a minor question I wanted to raise (see review).

interface/system/config_backup.rst Outdated Show resolved Hide resolved
@Hooverdan96
Copy link
Member Author

Statement is updated to new phrasing.

Copy link
Member

@phillxnet phillxnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hooverdan96 This is a much needed clarification. And we will get to enabling this capability in time.

Thanks for seeing to this doc improvement, always welcome as our docs are key to folks understanding of what to expect.

I'll get to merging and publishing these changes shortly. And thanks for the various other tidy-ups here. Again, always much appreciated.

interface/system/config_backup.rst Show resolved Hide resolved
@phillxnet
Copy link
Member

@FroggyFlox Thanks for the initial suggestion here. Much appreciated.

@phillxnet phillxnet merged commit cb5651b into rockstor:master Oct 8, 2024
3 checks passed
@phillxnet
Copy link
Member

PR product PRODUCTION published.

@Hooverdan96 Hooverdan96 deleted the 487_clarify_SMB_restore branch October 8, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Note that SMB export restore does not as-yet re-assert custom settings cleanup configuration backup restore
3 participants