-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify Samba restore restrictions #487 #492
Clarify Samba restore restrictions #487 #492
Conversation
Fixes rockstor#487. Add comment clarifying which parts of Samba exports can't be restored yet.
@phillxnet, see whether this is sufficient to clarify until there is time to address this gap. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for taking care of this so quickly, @Hooverdan96 ! It's much better to have that specified in our docs to clarify the situation.
I only have a minor question I wanted to raise (see review).
Statement is updated to new phrasing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hooverdan96 This is a much needed clarification. And we will get to enabling this capability in time.
Thanks for seeing to this doc improvement, always welcome as our docs are key to folks understanding of what to expect.
I'll get to merging and publishing these changes shortly. And thanks for the various other tidy-ups here. Again, always much appreciated.
@FroggyFlox Thanks for the initial suggestion here. Much appreciated. |
PR product PRODUCTION published. |
Fixes #487
Fixes #457
This pull request's proposal
Add comment clarifying which parts of Samba exports can't be restored yet.
Checklist