Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OEM guidelines doc entry #496 #498

Merged
merged 4 commits into from
Oct 21, 2024

Conversation

phillxnet
Copy link
Member

@phillxnet phillxnet commented Oct 14, 2024

Fixes #496

This pull request's proposal

Doc entry intended as a guide for original equipment manufacturers/suppliers (OEMs), NAS hardware sellers, and value-added resellers (VARs) interested in bundling Rockstor with hardware they source/build/redistribute.

Checklist

  • With the proposed changes no Sphinx errors or warnings are generated.
  • I have added my name to the AUTHORS file, if required (descending alphabetical order).

Doc entry intended as a guide for original equipment manufacturers/suppliers
OEMs/NAS hardware sellers, and value-added resellers (VARs) interested in
bundling Rockstor with hardware they source/build/redistribute.
@phillxnet phillxnet added the needs review must have clean Sphinx build and readability in html label Oct 14, 2024
Copy link
Member

@Hooverdan96 Hooverdan96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phillxnet, thanks for pulling this document together. This should go a long way to clarify a possible relation ship with 3rd party providers.
Does it make sense to post the subscription/engagement cost here? Probably yes for now, but for maintenance purposes it's will probably benefit to centralize some type of price list, so updates in the future will have only to be done in one place (like one sees often times as a "pricing" menu on the official website in other places).

howtos/oem-guide.rst Outdated Show resolved Hide resolved
howtos/oem-guide.rst Outdated Show resolved Hide resolved
howtos/oem-guide.rst Outdated Show resolved Hide resolved
- All rockstor distributed code is FSF Free/Libre & OSI approved and available on our
`GitHub Organisation <https://github.com/rockstor>`_ site.

- All 'rockstor' rpm packages are source (--format sdist) in-nature: i.e. non binary.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All 'rockstor' rpm packages are source (--format sdist) in-nature: i.e. non-binary.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hooverdan96 What is the actual change suggested here? Dropping the bullet point? But that doesn't seem correct. I'm assuming you wanted to remove the hyphen in "in-nature".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the hyphen in-nature and add the hyphen to non-binary ...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so I was half way there. Lets see to this in the next revision as we are essentially there now I think re first published version.

howtos/oem-guide.rst Outdated Show resolved Hide resolved
howtos/oem-guide.rst Outdated Show resolved Hide resolved
howtos/oem-guide.rst Show resolved Hide resolved
howtos/oem-guide.rst Outdated Show resolved Hide resolved
howtos/oem-guide.rst Outdated Show resolved Hide resolved
howtos/oem-guide.rst Outdated Show resolved Hide resolved
@phillxnet
Copy link
Member Author

@Hooverdan96 Thanks for taking a look at this proposal, and the suggestions. Much appreciated. I'll work through them shortly:
Re:

Does it make sense to post the subscription/engagement cost here?

Not really, I popped it in here just for comment really. And to given an indication to those interested prior to us creating the actual Open Collective Tier. It also provides, again for now, context for our planed, and proposed Tiers. In the context of our only actual Tier re the updates. I'll leave as-is for now I think and we can edit as we end up creating these Tiers in our Open Collective.

@Hooverdan96
Copy link
Member

sounds good to me.

@phillxnet
Copy link
Member Author

  • 2 new un-realted to this PR flaky links have emerged
(interface/system/update_channels: line   16) broken    https://opensource.org/license/apache-2-0 - 403 Client Error: Forbidden for url: https://opensource.org/license/apache-2-0
(interface/system/update_channels: line   16) broken    https://opensource.org/license/mit-0 - 403 Client Error: Forbidden for url: https://opensource.org/license/mit-0

@Hooverdan96
Copy link
Member

I ran into the same two during my Plex Rockon PR ... they work when accessed by a "real" user, it seems, but not by the linkcheck

@phillxnet
Copy link
Member Author

@Hooverdan96 My apologies, I somehow missed some of your suggestions, they didn't show-up in my presumably out-of-date view. So I've now committed via a follow-up commit. All but the combination change are now in this PR.

Again thanks for the more-eyes on this one.

We can revise as we we go, if deemed appropriate, as we get reflections/feedback from the target audience; but good to be first-publishing only after such initial corrections/improvements.

@FroggyFlox see anything clearly wrong in this initial draft? I think @Hooverdan96 has pretty much covered my initial failings here :) .

@phillxnet
Copy link
Member Author

I've also just noticed a "the The"!!! Now fixed and popped in @Hooverdan96's remaining hyphen while there. I think this is ready now so I'll get this published before it 'develops' yet more typos.

@phillxnet phillxnet merged commit 6c3bb73 into rockstor:master Oct 21, 2024
2 of 3 checks passed
@phillxnet phillxnet deleted the 496-OEM-guidelines-doc-entry branch October 21, 2024 14:06
@phillxnet phillxnet removed the needs review must have clean Sphinx build and readability in html label Oct 21, 2024
@phillxnet
Copy link
Member Author

PR product PRODUCTION published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OEM guidelines doc entry
2 participants