Update Plex Rockon Documentation

[Hooverdan96]

Fixes #214 and #172 .

Update of Plex Rockon Documentation:

• newer screenshots

• refactoring descriptions

• include transcoding explanation

• add workaround when no Plex account is used

• With the proposed changes no Sphinx errors or warnings are generated.

• I have added my name to the AUTHORS file, if required (descending alphabetical order).

[Hooverdan96]

These are the three linkcheck failures:

(interface/docker-based-rock-ons/plex-media-server: line   54) broken    https://ark.intel.com/ - 403 Client Error: Forbidden for url: https://ark.intel.com/
(interface/system/update_channels: line   16) broken    https://opensource.org/license/mit-0 - 403 Client Error: Forbidden for url: https://opensource.org/license/mit-0
(interface/system/update_channels: line   16) broken    https://opensource.org/license/apache-2-0 - 403 Client Error: Forbidden for url: https://opensource.org/license/apache-2-0

However, when manually accessing these three, they come up fine (no visible redirects or other address changes).

[Hooverdan96]

@FroggyFlox, @phillxnet I'm sure I missed some stuff, please take a look and make suggestions for change.

[phillxnet]

@Hooverdan96 Just having a looks at this now:
We seem to have gained the following:

(interface/docker-based-rock-ons/plex-media-server: line   54) broken    https://ark.intel.com/ - 403 Client Error: Forbidden for url: https://ark.intel.com/

But works fine in normal browser and redirects to: https://ark.intel.com/content/www/us/en/ark.html

So this may be a candidate, when re-visiting, to add our ignored list as we have the two you posted here already to add also.

Just reviewing changes currently, and this is not a show-stopper so no worries really. Just wanted to add to the known flaky urls as and when we see them.

[EDIT] My apologies: I see you already listed this!!

[phillxnet]

@Hooverdan96 Just a question up-front: why was your indicated Plex user, also a Rockstor Web-UI admin user?

Also was the following an intentional formatting:

[EDIT] I've popped in a suggested fix (hopefully) for the link format via the now completed review.

[Hooverdan96]

The admin user was not planned. I just had it created in that "demo" instance that way. I can clarify (or create a different screenshot for that.
and the formatting above, was not intentional. I think that's how it was before, and I just moved the text block. Let me fix that.

[Hooverdan96]

@phillxnet, I rebased the fork based on your most recent merge, updated the User screenshot and fixed the link you mentioned above.
The 3 linkcheck errors are still the same as they mentioned above as well.

[phillxnet]

@Hooverdan96 This is a nice improvement on what we had which was now a little dated. As always much appreciated.

I've made a few suggested improvements via the review. But my main concern here is the use of an Admin user (in picture); when text suggests non-admin user: which I think is preferred. Plus the share owner and group pic/text anomaly similarly. That is a regression re-setup I think.

See what you think.

[phillxnet]

I can clarify (or create a different screenshot for that.

That would be preferred if you have the time, thanks. That way we get folks using what is a safer arrangement from the get-go.

I think that's how it was before, and I just moved the text block. Let me fix that.

No worries, I've suggested a fix in the review. I hope the review suggestions are still valid as you look to have re-based and modifieed while I was reviewing. I can always re-do if the suggested changes no longer tally.

[Hooverdan96]

@phillxnet, ok I think I have now captured everything I can think of, including all of your suggestions.

[phillxnet]

@Hooverdan96 The only thing I see amiss after these changes is that the plex_share_owner.png file still looks to be root.root with default settings. Should this not be plex.plex with no 'other' access? With this share config Plex would have no write access. As I suspect you have the image there, do you fancy popping that in on this PR. We can do anther time: I'm just not keen of publishing as-is given the no write access and non optimal owner.group. Given the text is all nice now, and we have the new non-admin plex user image.

[Hooverdan96]

no, you're right, I thought I had done it ... starting too long at your own writing/pictures makes you overlook crucial things. I will update the view.

[Hooverdan96]

@phillxnet, ok I misread one of your earlier suggestions and only associated that with the plex user being part of the admin group. The share owner under the Access Control tab screenshot is now updated as well.

[phillxnet]

@Hooverdan96 Thanks again for all this effort, this is a major improvement and it's nice to now have this key guide updated re the transcoding option/Share. And to have more refined explanations etc.

About to merge and get this published shortly.

[phillxnet]

PR product PRODUCTION published.