Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker.md #2052

Merged
merged 3 commits into from
May 2, 2024
Merged

docker.md #2052

merged 3 commits into from
May 2, 2024

Conversation

gannazhyrnova
Copy link
Contributor

@gannazhyrnova gannazhyrnova commented May 2, 2024

Grammar check
@wsoyinka , @sspencerwire we need normal names instead of nishaaaaaant, sastorsl

Author checklist (Completed by original Author)

  • Good fit for the Rocky Linux project? Title and Author Metatags inserted ?
  • If applicable, steps and instructions have been tested to work
  • Initial self-review to fix basic typos and grammar completed

Rocky Documentation checklist (Completed by Rocky team)

  • 1st Pass (Document is good fit for project and author checklist completed)
  • 2nd Pass (Technical Review - check for technical correctness)
  • 3rd Pass (Detailed Editorial Review and Peer Review)
  • Final approval (Final Review)

gannazhyrnova and others added 2 commits May 2, 2024 12:39
Grammar check
@wsoyinka , @sspencerwire we need normal names instead of nishaaaaaant, sastorsl
Resolve github user handles to full-names and update contributor tag/field.
sspencerwire
sspencerwire previously approved these changes May 2, 2024
Copy link
Contributor

@sspencerwire sspencerwire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've always encouraged real names over Github handles, but have allowed them in the past. This document is not the only one that features Github handles, rather than real names. I think we will have a problem with the way this is formatted, too, as it may cause the contributors, or possibly even the entire meta tags at the top, to be malformed. The reason is that the contributors should appear on one line, and be comma-separated, rather than having LF's after the comma. I'll edit that before merging.

@sspencerwire sspencerwire merged commit a864c9b into rocky-linux:main May 2, 2024
2 checks passed
Copy link

github-actions bot commented May 2, 2024

Test results for 9f79180:

Number of broken URLs: 3

URL,RESULT,FILENAME
 https://azuremarketplace.microsoft.com/en-us/marketplace/apps/resf.rockylinux-aarch64,failed,guides/cloud/migration-to-new-azure-images.md
 https://rockylinux.org/community-charter/,failed,guides/contribute/README.md
 http://www.neelc.org/,failed,guides/contribute/README.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants