Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

06-profiles.md #2372

Merged
merged 2 commits into from
Sep 16, 2024
Merged

06-profiles.md #2372

merged 2 commits into from
Sep 16, 2024

Conversation

gannazhyrnova
Copy link
Contributor

@gannazhyrnova gannazhyrnova commented Sep 15, 2024

grammar changes

Author checklist (Completed by original Author)

  • Good fit for the Rocky Linux project? Title and Author Metatags inserted ?
  • If applicable, steps and instructions have been tested to work
  • Initial self-review to fix basic typos and grammar completed

Rocky Documentation checklist (Completed by Rocky team)

  • 1st Pass (Document is good fit for project and author checklist completed)
  • 2nd Pass (Technical Review - check for technical correctness)
  • 3rd Pass (Detailed Editorial Review and Peer Review)
  • Final approval (Final Review)

grammar changes

There are ways to get around this, but it is annoying. This appears to have something to do with changes made to Network Manager that affect `macvlan`. `macvlan` allows you to create many interfaces with different Layer 2 addresses.
There are ways to get around this, but it isn't very pleasant. This appears to have something to do with changes made to Network Manager that affect `macvlan`. `macvlan` allows you to create many interfaces with different Layer 2 addresses.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"isn't very pleasant" introduces a conjunction, which we do not want. Perhaps "is not very pleasant."


```bash
incus shell rockylinux-test-9
```

Next, lets determine the path to `dhclient`. To do this, because this container is from a minimal image, you will need to first install `which`:
Next, let's determine the path to `dhclient`. To do this, because this container is from a minimal image, you will need first to install `which`:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad on the "lets" BUT, change the conjunction here to "let us"

Copy link
Contributor

@sspencerwire sspencerwire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change out the two conjunctions mentioned. Otherwise, this looks good.

remove conjunctions
Copy link

Test results for f551c8b:

Number of broken URLs: 1

URL,RESULT,FILENAME
 https://azuremarketplace.microsoft.com/en-us/marketplace/apps/resf.rockylinux-aarch64,failed,guides/cloud/migration-to-new-azure-images.md

@sspencerwire sspencerwire merged commit c4236fc into rocky-linux:main Sep 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants