Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to set mirror base url for migration #92

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

m41kc0d3
Copy link

@m41kc0d3 m41kc0d3 commented Aug 9, 2021

No description provided.

@pajamian
Copy link
Collaborator

pajamian commented Aug 9, 2021

I'll have a closer look at this tomorrow. At first glance it looks to be an absolutely massive patch for such a presumably simple feature request.

@m41kc0d3
Copy link
Author

m41kc0d3 commented Aug 9, 2021

That's what I thought when I started, too. Then somehow one thing came after the other. ;)

@pajamian
Copy link
Collaborator

pajamian commented Aug 9, 2021

This patch is a definite -1 from me, I would consider a full rewrite of it but I don't see the need for "mirror file prefix" and "mirror name suffix". A simple baseurl path argument where each repo can be found under a fixed path (or one of two or three different fixed paths) under the prefix should suffice. If that will work for you then I'll work something up.

@m41kc0d3
Copy link
Author

The script dynamically determines the used repos. So I had thought that a dynamic takeover of the normal repos is a good idea, hence the prefix and suffix.
And for the script user I thought it is good to be able to control this and use the files immediately for his environment.

But if you think this is too complex then feel free to implement a simpler variant.

@m41kc0d3
Copy link
Author

Did you think about the patch or an other variant of it?

@pajamian
Copy link
Collaborator

This patch is way over-complicated, plus it has a large number of bash coding pitfalls. I will look into writing something more appropriate when I can, but $dayjob takes priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants