-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some SDIO lib cleanup. #696
Open
saloid
wants to merge
28
commits into
rogerclarkmelbourne:master
Choose a base branch
from
saloid:SDIO-trying
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from main repo
updating to actual version
Update local repo
This reverts commit f6540ec.
This reverts commit 70c7fb7.
This reverts commit fb13c19.
This reverts commit 957238e.
This reverts commit f208149.
This reverts commit 857315e.
This reverts commit 17604cc.
This reverts commit 2c6451d.
This reverts commit aa0f0f7.
This reverts commit b42121a.
This reverts commit d04f9c8.
This reverts commit f35abf3.
I'm fine with those clean ups, I planned to clean up and never did, but why are you commenting out this whole function? |
Sorry, currently I am AFK, but as I remember, same function was in another place. This PR still not finished, I will do some stuff and add examples soon. |
@saloid , what is the status of this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If somebody have code examples for this lib - help me, please.