Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for INF and NAN #39

Merged
merged 2 commits into from
Apr 30, 2019
Merged

Add support for INF and NAN #39

merged 2 commits into from
Apr 30, 2019

Conversation

Kampfkarren
Copy link
Member

Closes #33

Kampfkarren
Kampfkarren commented Apr 25, 2019
View reviewed changes
rbx_xml/src/types/numbers.rs
Ok(())
}

#[allow(clippy::zero_divided_by_zero)]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither std::$rust_type::NAN nor std::<$rust_type>::NAN compile, so 0.0 / 0.0 is needed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd expect std::<$rust_type>::NAN to compile, interesting.

Copy link
Contributor

@LPGhatguy LPGhatguy Apr 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at least there's a bug for it: rust-lang/rust#48067

I guess we could use paste but if we aren't already using it elsewhere then it's a waste.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this isn't bad enough for readability to matter?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's proabbly fine.

LPGhatguy
LPGhatguy approved these changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@LPGhatguy LPGhatguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray!

@LPGhatguy LPGhatguy merged commit 966640c into rojo-rbx:master Apr 30, 2019
@Kampfkarren Kampfkarren mentioned this pull request Jun 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LPGhatguy LPGhatguy LPGhatguy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for INF/NAN in rbx_xml
2 participants
@Kampfkarren @LPGhatguy