Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to using PEP 508 #382

Merged
merged 2 commits into from
Jun 22, 2021
Merged

Switch to using PEP 508 #382

merged 2 commits into from
Jun 22, 2021

Conversation

jackton1
Copy link
Contributor

@jackton1 jackton1 commented Jun 17, 2021 •
edited by bxsx
Loading

Description of the change

Specify dependencies using Environment markers.

@bxsx

Type of change

  • Enhancement that improves existing code
  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

bxsx
bxsx approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@bxsx bxsx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jackton1 and thank you so much for your contribution 💪
This is a nice improvement that I'm merging now and will be added to the next release.

@bxsx bxsx merged commit f67253a into rollbar:master Jun 22, 2021
@bxsx bxsx self-assigned this Jun 22, 2021
@jackton1 jackton1 deleted the patch-2 branch June 22, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bxsx bxsx bxsx approved these changes

Assignees

@bxsx bxsx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackton1 @bxsx