Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing code_version in payload and don't set optional fields if … #5

Merged
merged 1 commit into from
Sep 1, 2021

Conversation

diegov
Copy link
Contributor

@diegov diegov commented Aug 19, 2021

Description of the change

This PR fixes the missing code_version field in the payload, if provided.

It also updates other optional fields so that they're only added to the payload if they are not null.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

  • Fix [ch90062]

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #90062: rollbar-flutter: missing code_version in payload.

@diegov diegov marked this pull request as draft August 19, 2021 16:09
@diegov diegov force-pushed the diegoveralli/add_code_version branch from b7eb803 to 0480d39 Compare August 19, 2021 16:45
@diegov diegov marked this pull request as ready for review August 19, 2021 16:45
@diegov diegov merged commit 8e8a052 into main Sep 1, 2021
@diegov diegov deleted the diegoveralli/add_code_version branch September 23, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants