Recreate REQUEST_URI using Rack SPEC-compliant variables #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joelvh Thank you for the PR. |
|
No problem @waltjones! |
|
Released in v2.26.1 https://github.com/rollbar/rollbar-gem/releases/tag/v2.26.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out
REQUEST_URIis not in the Rack SPEC, and the recommendation is to reproduce the same value using SPEC-compliant variables.Rack::Request#fullpathbuilds the equivalent ofREQUEST_URI, but we don't want to add a dependency onRackdirectly.The update uses Rack-compliant variables.