Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove arrow functions in browser target #1073

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

waltjones
Copy link
Contributor

@waltjones waltjones commented Dec 20, 2022

Description of the change

This PR removes arrow functions that aren't compatible with IE11 and some other browsers. (The Rollbar.js build process currently doesn't include a transpile step that would make this compatible.)

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Related issues

Fixes #1064

https://app.shortcut.com/rollbar/story/120517

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arrow function does not work in IE11
2 participants