Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix transform declaration #981

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Fix transform declaration #981

merged 1 commit into from
Jan 11, 2022

Conversation

axelmorvan
Copy link
Contributor

Description of the change

Willing to add Rollbar to a project, I noticed that we are missing the declaration of item in the transform since the PR #650.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@waltjones waltjones self-requested a review January 10, 2022 14:40
waltjones
waltjones approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@waltjones waltjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@axelmorvan THanks for the PR. I'll merge when CI completes.

@waltjones waltjones merged commit 0aab52d into rollbar:master Jan 11, 2022
This was referenced Mar 16, 2022
Merged
Merged
Merged
Open
@renovate renovate bot mentioned this pull request Mar 26, 2022
Open
1 task
@eliten00b eliten00b mentioned this pull request Jul 1, 2022
Merged
12 tasks
mudetroit pushed a commit that referenced this pull request Mar 14, 2024
@axelmorvan
Fix transform declaration (#981)
666171e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waltjones waltjones waltjones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axelmorvan @waltjones