feat: Implement Course Cards #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
components/School/school.tsx
Outdated
| }; | ||
|
|
||
| const School: FC<Props> = ({ courses, limit }) => { | ||
| const sorted = useMemo( |
There was a problem hiding this comment.
I think it's better to use a more descriptive name
sortedCourses as example
components/School/school.tsx
Outdated
| </div> | ||
|
|
||
| <div className={styles.cards}> | ||
| <CourseList courses={sorted || []} /> |
There was a problem hiding this comment.
if I'm not mistaken sorted will be an array anyway
<CourseList courses={sorted} />
SyleimanovSergey
approved these changes
Feb 16, 2023
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
crzoukman
force-pushed
the
feature/issue-40/implement-rs-school-block
branch
from
13c6108 to
ef76fff
Compare
alexey-koran
force-pushed
the
feature/issue-40/implement-rs-school-block
branch
from
ef76fff to
60ee6b3
Compare
alexey-koran
force-pushed
the
feature/issue-40/implement-rs-school-block
branch
from
4d66658 to
fcfd9a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🟢 Add
deploylabel if you want to deploy this Pull Request to staging environment🧑⚖️ Pull Request Naming Convention
area:*label(s)🤔 This is a ...
🔗 Related issue link
#40
💡 Background and solution
Describe the big picture of your changes here
☑️ Self Check before Merge