-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: init mdbooks for specs site with place holder files #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MSevey
force-pushed
the
sevey/mdbooks-specs
branch
2 times, most recently
from
September 20, 2023 10:15
80971ca
to
6a2c006
Compare
MSevey
force-pushed
the
sevey/mdbooks-specs
branch
from
September 20, 2023 10:18
6a2c006
to
edac698
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1199 +/- ##
==========================================
+ Coverage 56.04% 56.05% +0.01%
==========================================
Files 63 63
Lines 6695 6695
==========================================
+ Hits 3752 3753 +1
Misses 2556 2556
+ Partials 387 386 -1 ☔ View full report in Codecov by Sentry. |
nashqueue
requested changes
Sep 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you , LGTM apart from 3 nits
Co-authored-by: nashqueue <[email protected]>
Manav-Aggarwal
approved these changes
Sep 20, 2023
nashqueue
approved these changes
Sep 20, 2023
gupadhyaya
pushed a commit
that referenced
this pull request
Sep 22, 2023
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> ## Overview <!-- Please provide an explanation of the PR, including the appropriate context, background, goal, and rationale. If there is an issue with this information, please provide a tl;dr and link the issue. --> This PR adds [mdbook](https://rust-lang.github.io/mdBook/guide/installation.html) for hosting the specs site. A workflow was added to deploy the specs site to github pages. ## Checklist <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [ ] New and updated code has appropriate documentation - [ ] New and updated code has new and/or updated testing - [ ] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords --------- Co-authored-by: nashqueue <[email protected]>
chandiniv1
pushed a commit
to chandiniv1/rollkit
that referenced
this pull request
Sep 25, 2023
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> ## Overview <!-- Please provide an explanation of the PR, including the appropriate context, background, goal, and rationale. If there is an issue with this information, please provide a tl;dr and link the issue. --> This PR adds [mdbook](https://rust-lang.github.io/mdBook/guide/installation.html) for hosting the specs site. A workflow was added to deploy the specs site to github pages. ## Checklist <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [ ] New and updated code has appropriate documentation - [ ] New and updated code has new and/or updated testing - [ ] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords --------- Co-authored-by: nashqueue <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds mdbook for hosting the specs site. A workflow was added to deploy the specs site to github pages.
Checklist