Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

namedExports is now deprecated #410

Merged
merged 1 commit into from
May 29, 2020
Merged

namedExports is now deprecated #410

merged 1 commit into from
May 29, 2020

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented May 24, 2020

Rollup Plugin Name: commonjs

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

As the commit message, namedExports option of @rollup/plugin-commonjs is deprecated, so remove it from related types.

@shellscape
Copy link
Collaborator

Please add a thorough description to PRs. We won't consider PRs unless all fields have been properly filled out.

@JounQin
Copy link
Contributor Author

JounQin commented May 24, 2020

OK, I just thought the commit message was fair enough.

@shellscape shellscape merged commit f3cc2be into rollup:master May 29, 2020
@JounQin JounQin deleted the patch-1 branch May 30, 2020 02:52
@littlewords
Copy link

so how to resolve this problem
https://rollupjs.org/guide/en/#error-name-is-not-exported-by-module

@joshribakoff
Copy link

Yes, I'm also frustrated to land here & see this merged with such a sparse description, and without updating docs. I cannot build my project at all right now :(

rollup/rollup#3755

@shellscape
Copy link
Collaborator

@joshribakoff while it stinks when stuff doesn't work, please do try to avoid venting frustrations by cross posting. If you believe that there's a bug with this plugin, please open a new bug issue (and pay close attention to the issue template - we're big on minimal reproductions).

We're locking this one for now, since the PR is merged and this is attracting follow-up comments that are better served as issues.

@rollup rollup locked as resolved and limited conversation to collaborators Aug 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants