Skip to content
This repository has been archived by the owner on Aug 4, 2021. It is now read-only.

Added support for ancient ES3 browsers #381

Merged
merged 1 commit into from
Apr 2, 2019
Merged

Conversation

sormy
Copy link
Contributor

@sormy sormy commented Mar 30, 2019

Added support for ancient ES3 browsers, like IE6, IE7, IE8 without breaking compatibility with modern browsers. The build output after minifiers will depend on minifier configuration. For example, uglifyjs will keep x['default'] if { ie8: true } is set and will convert back to x.default if not set. This is a safe change that will add ES3 support for free without impact on modern browsers.

Fixes #364

@sormy sormy mentioned this pull request Mar 30, 2019
@sormy
Copy link
Contributor Author

sormy commented Apr 1, 2019

Hi, babel got recently merged full es3 support as a part of preset-es3 (babel/babel#9781). It could be really nice to have rollup to also support es3 and the change needed for commonjs is pretty small. Let me know if I can do anything else to move forward with this PR. Thank you.

@lukastaegert
Copy link
Member

Hi @sormy,

I will not make any promises for Rollup itself supporting ES3 any time soon—not too long ago, we removed legacy mode as it was basically too hard to maintain without proper ES3 environment tests and there is a lot of different auto-generated code that will not work in such an environment. Nevertheless, I could see us accomodate this specific change as long as this is not seen as a promise to become fully ES3 compliant.

@lukastaegert lukastaegert merged commit dc82347 into rollup:master Apr 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants