Skip to content

Commit

Permalink
Stop using lvalue/rvalue in Reflection module docs (chapel-lang#24754)
Browse files Browse the repository at this point in the history
These terms are a bit jargony and should be replaced with clearer
language.

[reviewed-by @lydia-duncan]
  • Loading branch information
benharsh authored Apr 3, 2024
2 parents 737db20 + dae15c4 commit 7b12803
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions modules/standard/Reflection.chpl
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ proc getField(const ref obj:?t, param idx: int) type
:arg obj: a class or record
:arg idx: which field to get
:returns: an rvalue referring to that field.
:returns: a const reference to that field.
*/
pragma "unsafe"
inline proc getField(const ref obj:?t, param idx:int) const ref do
Expand Down Expand Up @@ -154,7 +154,7 @@ proc getField(const ref obj:?t, param name: string) type
:arg obj: a class or record
:arg name: the name of a field
:returns: an rvalue referring to that field.
:returns: a const reference to that field.
*/
pragma "unsafe"
inline proc getField(const ref obj:?t, param name:string) const ref {
Expand Down Expand Up @@ -210,7 +210,7 @@ proc getImplementationField(const ref x:?t, param i:int) const ref {
:arg x: a class or record
:arg i: which field to get
:returns: an rvalue referring to that field.
:returns: a mutable reference to that field.
*/
pragma "unsafe"
@unstable(reason="'getFieldRef' is unstable")
Expand All @@ -225,7 +225,7 @@ inline proc getFieldRef(ref x:?t, param i:int) ref {
:arg x: a class or record
:arg s: the name of a field
:returns: an rvalue referring to that field.
:returns: a mutable reference to that field.
*/
pragma "unsafe"
@unstable(reason="'getFieldRef' is unstable")
Expand Down

0 comments on commit 7b12803

Please sign in to comment.