Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add redux #417

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

add redux #417

wants to merge 5 commits into from

Conversation

mickeypause
Copy link

[cli] Added redux as a state management option

Description

  1. Added redux as an option to cli
  2. Wrapped every navigation into Provider
  3. Created a template with a demo store

Motivation and Context

Redux is still one of the most popular state management solutions used in production, with @reduxjs/toolkit having 3.6 million daily downloads. However, it takes a lot of effort to set it up due to the large amount of boilerplate code. These changes create a minimal Redux store and configure everything needed to start working with Redux immediately.

How Has This Been Tested?

Tested using bun run test and manually tested each option.

@dannyhw
Copy link
Collaborator

dannyhw commented Oct 27, 2024

hey sorry that we haven't gotten to this, its not forgotten we're just thinking about the best way to approach adding more options to the cli

Copy link
Collaborator

@dannyhw dannyhw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note and this is a minor thing but if you change unrelated indentation it makes it a bit harder to review what the changes are, I've reverted some of the indentation changes to make it easier to review.

@dannyhw
Copy link
Collaborator

dannyhw commented Nov 3, 2024

I added the changes also for the nativewindui layouts

@dannyhw
Copy link
Collaborator

dannyhw commented Nov 6, 2024

I've merged the other state management pr which has caused some conflicts but I can help resolve those soon so that we can also get this merged

@mickeypause
Copy link
Author

I've merged the other state management pr which has caused some conflicts but I can help resolve those soon so that we can also get this merged

If you want I can try to resolve those issues

@dannyhw
Copy link
Collaborator

dannyhw commented Nov 6, 2024

@mickeypause yes that would be great, thank you 🙏

@danstepanov
Copy link
Collaborator

@mickeypause Are you still interested in making this addition? If so, can you rebase and ping me? Otherwise, I'll close this PR by the end of the month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants