Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate rootlesskit-docker-proxy (no longer needed since Docker v28) #459

Merged
merged 1 commit into from
Aug 17, 2024
Merged

Deprecate rootlesskit-docker-proxy (no longer needed since Docker v28) #459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ bin/rootlessctl: $(GO_FILES)
$(GO) build -o $@ -v ./cmd/rootlessctl

bin/rootlesskit-docker-proxy: $(GO_FILES)
@echo "NOTE: rootlesskit-docker-proxy is required only if you use Docker prior to v28."
@echo "NOTE: rootlesskit-docker-proxy is DEPRECATED and will be removed in RootlessKit v3."
$(GO) build -o $@ -v ./cmd/rootlesskit-docker-proxy

.PHONY: cross
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ Run `make && sudo make install` .
The following binaries will be installed:
- `/usr/local/bin/rootlesskit`
- `/usr/local/bin/rootlessctl`
- `/usr/local/bin/rootlesskit-docker-proxy` (Can be safely removed if you do not use Docker)
- `/usr/local/bin/rootlesskit-docker-proxy` (DEPRECATED; Only required for Docker prior to [v28](https://github.com/moby/moby/pull/48132/commits/dac7ffa3404138a4f291c16586e5a2c68dad4151))

### Requirements

Expand Down
9 changes: 9 additions & 0 deletions cmd/rootlesskit-docker-proxy/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
// Package main provides the `rootlesskit-docker-proxy` binary (DEPRECATED)
// that was used by Docker prior to v28 for supporting rootless mode.
//
// The rootlesskit-docker-proxy binary is no longer needed since Docker v28,
// as the functionality of rootlesskit-docker-proxy is now provided by dockerd itself.
//
// https://github.com/moby/moby/pull/48132/commits/dac7ffa3404138a4f291c16586e5a2c68dad4151
//
// rootlesskit-docker-proxy will be removed in RootlessKit v3.
package main

import (
Expand Down