Skip to content
This repository has been archived by the owner on Jan 16, 2024. It is now read-only.

The SEO Framework + relative URLs #184

Merged
merged 1 commit into from
Jun 12, 2017
Merged

The SEO Framework + relative URLs #184

merged 1 commit into from
Jun 12, 2017

Conversation

retlehs
Copy link
Member

@retlehs retlehs commented Jun 12, 2017

fixes #181

@retlehs retlehs force-pushed the seo-framework-compat branch from aa4434d to a204bfc Compare June 12, 2017 01:13
@retlehs retlehs merged commit 5befe9c into master Jun 12, 2017
@retlehs retlehs deleted the seo-framework-compat branch June 12, 2017 01:16
@wassim
Copy link

wassim commented Jun 27, 2017

@retlehs any reasons behind this? The root domain is now duplicated and Facebook/Twitter can't parse it:

<meta property="og:image" content="http://domain.com/http://domain.com/app/uploads/..." />
<meta name="twitter:image" content="http://domain.com/http://domain.com/app/uploads/..." />

@retlehs
Copy link
Member Author

retlehs commented Jun 27, 2017

oh boy. things might have changed with a new version of the SEO framework. ill take a look - thanks for reporting

@JulienMelissas
Copy link
Contributor

oh damn, glad we haven't push this to production yet...

@retlehs
Copy link
Member Author

retlehs commented Jun 28, 2017

@wassim i'm unable to reproduce. please post on discourse with more details

@wassim
Copy link

wassim commented Jun 28, 2017

@retlehs #187

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using relative urls with The SEO Framework causes og:image to be relative
3 participants