droplet create command: Support ed25519 SSH keys #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for both ed25519 and rsa SSH keys. Previously this used `~/.ssh/id_rsa.pub` as the default `ssh-key` option value which forced users with ed25519 keys to manually specify the key path. Now trellis-cli will check both `~/.sss/id_ed25519.pub` and `~/.sss/id_rsa.pub` keys by default. This also improves failure handling and output of SSH key related functionality including outputting the path of the key being used to make it more obvious.
swalkinshaw
force-pushed
the
droplet-ssh-key-support-ed25519
branch
from
8e15f21 to
74d6d65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for both ed25519 and rsa SSH keys. Previously this used
~/.ssh/id_rsa.pubas the defaultssh-keyoption value which forced users with ed25519 keys to manually specify the key path.Now trellis-cli will check both
~/.sss/id_ed25519.puband~/.sss/id_rsa.pubkeys by default.This also improves failure handling and output of SSH key related functionality including outputting the path of the key being used to make it more obvious.